rtpmp4gdepay: Allow lower-case "aac-hbr" instead of correct "AAC-hbr"
authorSebastian Dröge <sebastian@centricular.com>
Mon, 14 Sep 2020 07:15:35 +0000 (10:15 +0300)
committerSebastian Dröge <sebastian@centricular.com>
Fri, 18 Sep 2020 07:02:44 +0000 (10:02 +0300)
Various live555 based products are using the wrong "mode" string or
seem to assume case-insensitive matching, which is wrong.

Examples for this are the Yuan SC6C0N1 mini and the Kiloview E2.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/727>

docs/gst_plugins_cache.json
gst/rtp/gstrtpmp4gdepay.c

index 2f1bfee..56b7a8c 100644 (file)
                 "long-name": "RTP MPEG4 ES depayloader",
                 "pad-templates": {
                     "sink": {
-                        "caps": "application/x-rtp:\n          media: { (string)video, (string)audio, (string)application }\n     clock-rate: [ 1, 2147483647 ]\n  encoding-name: MPEG4-GENERIC\n           mode: { (string)generic, (string)CELP-cbr, (string)CELP-vbr, (string)AAC-lbr, (string)AAC-hbr }\n",
+                        "caps": "application/x-rtp:\n          media: { (string)video, (string)audio, (string)application }\n     clock-rate: [ 1, 2147483647 ]\n  encoding-name: MPEG4-GENERIC\n           mode: { (string)generic, (string)CELP-cbr, (string)CELP-vbr, (string)AAC-lbr, (string)AAC-hbr, (string)aac-hbr }\n",
                         "direction": "sink",
                         "presence": "always"
                     },
index 5c4b454..a734be0 100644 (file)
@@ -53,7 +53,7 @@ GST_STATIC_PAD_TEMPLATE ("sink",
         /* "streamtype = (string) { \"4\", \"5\" }, "  Not set by Wowza    4 = video, 5 = audio */
         /* "profile-level-id = (string) [1,MAX], " */
         /* "config = (string) [1,MAX]" */
-        "mode = (string) { \"generic\", \"CELP-cbr\", \"CELP-vbr\", \"AAC-lbr\", \"AAC-hbr\" } "
+        "mode = (string) { \"generic\", \"CELP-cbr\", \"CELP-vbr\", \"AAC-lbr\", \"AAC-hbr\", \"aac-hbr\" } "
         /* Optional general parameters */
         /* "objecttype = (string) [1,MAX], " */
         /* "constantsize = (string) [1,MAX], " *//* constant size of each AU */