net/mlx4_core: Add missing iounmap() in error path
authorZou Wei <zou_wei@huawei.com>
Fri, 24 Apr 2020 13:53:14 +0000 (21:53 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sun, 26 Apr 2020 03:43:56 +0000 (20:43 -0700)
This fixes the following coccicheck warning:

drivers/net/ethernet/mellanox/mlx4/crdump.c:200:2-8: ERROR: missing iounmap;
ioremap on line 190 and execution via conditional on line 198

Fixes: 7ef19d3b1d5e ("devlink: report error once U32_MAX snapshot ids have been used")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Reviewed-by: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx4/crdump.c

index 73eae80..ac5468b 100644 (file)
@@ -197,6 +197,7 @@ int mlx4_crdump_collect(struct mlx4_dev *dev)
        err = devlink_region_snapshot_id_get(devlink, &id);
        if (err) {
                mlx4_err(dev, "crdump: devlink get snapshot id err %d\n", err);
+               iounmap(cr_space);
                return err;
        }