[GN] Locate prebuilt binaries correctly.
authorMitch Phillips <mitchphillips@outlook.com>
Thu, 7 Mar 2019 22:20:36 +0000 (22:20 +0000)
committerMitch Phillips <mitchphillips@outlook.com>
Thu, 7 Mar 2019 22:20:36 +0000 (22:20 +0000)
Use the system shell to see if we can find a 'gn' binary on $PATH. This solves the error wherein subprocess.call fails ungracefully if the binary doesn't exist.

llvm-svn: 355645

llvm/utils/gn/gn.py

index f523e64..73f2c80 100755 (executable)
@@ -38,7 +38,8 @@ def main():
     # Find real gn executable.
     gn = 'gn'
     if subprocess.call([gn, '--version'], stdout=open(os.devnull, 'w'),
-                                          stderr=subprocess.STDOUT) != 0:
+                                          stderr=subprocess.STDOUT,
+                                          shell=True) != 0:
         # Not on path. See if get.py downloaded a prebuilt binary and run that
         # if it's there, or suggest to run get.py if it isn't.
         platform = get_platform()