net: lantiq_etop: Fix return type for implementation of ndo_start_xmit
authorGUO Zihua <guozihua@huawei.com>
Fri, 2 Sep 2022 08:15:21 +0000 (16:15 +0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 3 Sep 2022 04:19:35 +0000 (21:19 -0700)
Since Linux now supports CFI, it will be a good idea to fix mismatched
return type for implementation of hooks. Otherwise this might get
cought out by CFI and cause a panic.

ltq_etop_tx() would return either NETDEV_TX_BUSY or NETDEV_TX_OK, so
change the return type to netdev_tx_t directly.

Signed-off-by: GUO Zihua <guozihua@huawei.com>
Link: https://lore.kernel.org/r/20220902081521.59867-1-guozihua@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/lantiq_etop.c

index 7cedbe1..59aab40 100644 (file)
@@ -470,7 +470,7 @@ ltq_etop_stop(struct net_device *dev)
        return 0;
 }
 
-static int
+static netdev_tx_t
 ltq_etop_tx(struct sk_buff *skb, struct net_device *dev)
 {
        int queue = skb_get_queue_mapping(skb);