NFSD: Replace READ* macros in nfsd4_decode_layoutget()
authorChuck Lever <chuck.lever@oracle.com>
Tue, 3 Nov 2020 20:06:04 +0000 (15:06 -0500)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 30 Nov 2020 19:46:42 +0000 (14:46 -0500)
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4xdr.c

index 0b8f7de..d397dce 100644 (file)
@@ -1844,24 +1844,27 @@ static __be32
 nfsd4_decode_layoutget(struct nfsd4_compoundargs *argp,
                struct nfsd4_layoutget *lgp)
 {
-       DECODE_HEAD;
-
-       READ_BUF(36);
-       lgp->lg_signal = be32_to_cpup(p++);
-       lgp->lg_layout_type = be32_to_cpup(p++);
-       lgp->lg_seg.iomode = be32_to_cpup(p++);
-       p = xdr_decode_hyper(p, &lgp->lg_seg.offset);
-       p = xdr_decode_hyper(p, &lgp->lg_seg.length);
-       p = xdr_decode_hyper(p, &lgp->lg_minlength);
+       __be32 status;
 
-       status = nfsd4_decode_stateid(argp, &lgp->lg_sid);
+       if (xdr_stream_decode_u32(argp->xdr, &lgp->lg_signal) < 0)
+               return nfserr_bad_xdr;
+       if (xdr_stream_decode_u32(argp->xdr, &lgp->lg_layout_type) < 0)
+               return nfserr_bad_xdr;
+       if (xdr_stream_decode_u32(argp->xdr, &lgp->lg_seg.iomode) < 0)
+               return nfserr_bad_xdr;
+       if (xdr_stream_decode_u64(argp->xdr, &lgp->lg_seg.offset) < 0)
+               return nfserr_bad_xdr;
+       if (xdr_stream_decode_u64(argp->xdr, &lgp->lg_seg.length) < 0)
+               return nfserr_bad_xdr;
+       if (xdr_stream_decode_u64(argp->xdr, &lgp->lg_minlength) < 0)
+               return nfserr_bad_xdr;
+       status = nfsd4_decode_stateid4(argp, &lgp->lg_sid);
        if (status)
                return status;
+       if (xdr_stream_decode_u32(argp->xdr, &lgp->lg_maxcount) < 0)
+               return nfserr_bad_xdr;
 
-       READ_BUF(4);
-       lgp->lg_maxcount = be32_to_cpup(p++);
-
-       DECODE_TAIL;
+       return nfs_ok;
 }
 
 static __be32