xen/pvcalls-back: test for errors when calling backend_connect()
authorJuergen Gross <jgross@suse.com>
Mon, 11 May 2020 07:42:31 +0000 (09:42 +0200)
committerBoris Ostrovsky <boris.ostrovsky@oracle.com>
Thu, 21 May 2020 17:59:15 +0000 (12:59 -0500)
backend_connect() can fail, so switch the device to connected only if
no error occurred.

Fixes: 0a9c75c2c7258f2 ("xen/pvcalls: xenbus state handling")
Cc: stable@vger.kernel.org
Signed-off-by: Juergen Gross <jgross@suse.com>
Link: https://lore.kernel.org/r/20200511074231.19794-1-jgross@suse.com
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
drivers/xen/pvcalls-back.c

index cf4ce3e..41a18ec 100644 (file)
@@ -1088,7 +1088,8 @@ static void set_backend_state(struct xenbus_device *dev,
                case XenbusStateInitialised:
                        switch (state) {
                        case XenbusStateConnected:
-                               backend_connect(dev);
+                               if (backend_connect(dev))
+                                       return;
                                xenbus_switch_state(dev, XenbusStateConnected);
                                break;
                        case XenbusStateClosing: