staging: qlge: Replace memset with assignment
authorBenjamin Poirier <bpoirier@suse.com>
Fri, 27 Sep 2019 10:12:08 +0000 (19:12 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 Oct 2019 15:17:46 +0000 (17:17 +0200)
Instead of clearing the structure wholesale, it is sufficient to initialize
the skb member which is used to manage sbq instances. lbq instances are
managed according to curr_idx and clean_idx.

Signed-off-by: Benjamin Poirier <bpoirier@suse.com>
Link: https://lore.kernel.org/r/20190927101210.23856-15-bpoirier@suse.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/qlge/qlge_main.c

index 8da5969..009934b 100644 (file)
@@ -2807,11 +2807,10 @@ static int qlge_init_bq(struct qlge_bq *bq)
        if (!bq->queue)
                return -ENOMEM;
 
-       memset(bq->queue, 0, QLGE_BQ_LEN * sizeof(struct qlge_bq_desc));
-
        buf_ptr = bq->base;
        bq_desc = &bq->queue[0];
        for (i = 0; i < QLGE_BQ_LEN; i++, buf_ptr++, bq_desc++) {
+               bq_desc->p.skb = NULL;
                bq_desc->index = i;
                bq_desc->buf_ptr = buf_ptr;
        }