kdbus: drop KDBUS_HELLO_UNPRIVILEGED (API break)
authorDavid Herrmann <dh.herrmann@gmail.com>
Mon, 12 Jan 2015 13:29:55 +0000 (14:29 +0100)
committerDavid Herrmann <dh.herrmann@gmail.com>
Mon, 12 Jan 2015 13:37:28 +0000 (14:37 +0100)
This flag is unused and we have no real use-case for it. Drop it.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
connection.c
handle.c
kdbus.h

index d7357b65bacbe727d6d1664948885db74d31846a..218e11d42a18e69f895f7aebe019d0a7cc363077 100644 (file)
@@ -1539,8 +1539,7 @@ struct kdbus_conn *kdbus_conn_new(struct kdbus_ep *ep,
        conn->cred = get_current_cred();
        init_waitqueue_head(&conn->wait);
        kdbus_queue_init(&conn->queue);
-       conn->privileged = privileged &&
-                          !(hello->flags & KDBUS_HELLO_UNPRIVILEGED);
+       conn->privileged = privileged;
        conn->ep = kdbus_ep_ref(ep);
        conn->id = atomic64_inc_return(&bus->conn_seq_last);
        conn->flags = hello->flags;
index 991dcd6464c0ba6c67d64c244bb2b94f17965ba3..313247690576a94b5f2c5eb36b32b5ac06156a70 100644 (file)
--- a/handle.c
+++ b/handle.c
@@ -240,8 +240,7 @@ static int handle_ep_ioctl_hello(struct kdbus_handle_ep *handle,
                                    KDBUS_HELLO_ACCEPT_FD |
                                    KDBUS_HELLO_ACTIVATOR |
                                    KDBUS_HELLO_POLICY_HOLDER |
-                                   KDBUS_HELLO_MONITOR |
-                                   KDBUS_HELLO_UNPRIVILEGED);
+                                   KDBUS_HELLO_MONITOR);
        if (ret < 0)
                goto exit;
 
diff --git a/kdbus.h b/kdbus.h
index e9d9c9f31b367c0bd371139c27f89c0f57b69e3d..a7cb86f677979b40cd51e8db2c5d4aeb8ac777b7 100644 (file)
--- a/kdbus.h
+++ b/kdbus.h
@@ -634,15 +634,12 @@ enum kdbus_policy_type {
  *                             a service
  * @KDBUS_HELLO_MONITOR:       Special-purpose connection to monitor
  *                             bus traffic
- * @KDBUS_HELLO_UNPRIVILEGED:  Don't treat this connection as privileged once
- *                             the bus connection was established.
  */
 enum kdbus_hello_flags {
        KDBUS_HELLO_ACCEPT_FD           =  1ULL <<  0,
        KDBUS_HELLO_ACTIVATOR           =  1ULL <<  1,
        KDBUS_HELLO_POLICY_HOLDER       =  1ULL <<  2,
        KDBUS_HELLO_MONITOR             =  1ULL <<  3,
-       KDBUS_HELLO_UNPRIVILEGED        =  1ULL <<  4,
 };
 
 /**