Coverity Issue fixes for Calendar

Change-Id: Idfcf13f1393c54837bd07fce9d97b0ec46f1d8ca
Signed-off-by: kamaljeet <kamal.jc@samsung.com>

diff --git a/common/dbus/cal_dbus_helper.c b/common/dbus/cal_dbus_helper.c
index a4b6a19..65c292e 100644 (file)
--- a/common/dbus/cal_dbus_helper.c
+++ b/common/dbus/cal_dbus_helper.c
@@ -1749,7 +1749,8 @@ int cal_dbus_utils_gvariant_to_list(GVariant *arg_list_pack, calendar_list_h *ou
                        if (CALENDAR_ERROR_NONE != ret)
                                break;
 
-                       calendar_list_add(l, record);
+                       if (calendar_list_add(l, record) != CALENDAR_ERROR_NONE)
+                               DBG(" calendar_list_add Failed \n ");
                }
        }
 

diff --git a/server/cal_server.c b/server/cal_server.c
index 49f99ee..159efc4 100644 (file)
--- a/server/cal_server.c
+++ b/server/cal_server.c
@@ -245,7 +245,8 @@ static void _cal_server_create_directory(const char* directory, mode_t mode)
                return;
 
        DBG("No directory[%s]", directory);
-       mkdir(directory, mode);
+       if (mkdir(directory, mode) != 0)
+               printf("Failed to make new directory\n");
 }
 
 static void _cal_server_set_directory_permission(const char* file, mode_t mode)

diff --git a/server/cal_server_schema.c b/server/cal_server_schema.c
index 1a259db..f5cf586 100644 (file)
--- a/server/cal_server_schema.c
+++ b/server/cal_server_schema.c
@@ -200,9 +200,12 @@ int cal_server_schema_check(void)
                if (ret == -2) {
                        /* LCOV_EXCL_START */
                        ERR("need_to_remove(%d)", ret);
-                       remove(CAL_DB_SHM_FILE);
-                       remove(CAL_DB_WAL_FILE);
-                       remove(CAL_DB_FILE);
+                       if (remove(CAL_DB_SHM_FILE) != 0)
+                               ERR("Failed to remove CAL_DB_SHM_FILE");
+                       if (remove(CAL_DB_WAL_FILE) != 0)
+                               ERR("Failed to remove CAL_DB_WAL_FILE");
+                       if (remove(CAL_DB_FILE))
+                               ERR("Failed to remove CAL_DB_FILE");
                        need_to_remove = false;
                /* LCOV_EXCL_STOP */
                } else {

diff --git a/server/db/cal_db_plugin_instance_localtime.c b/server/db/cal_db_plugin_instance_localtime.c
index ca7c263..c2ec67c 100644 (file)
--- a/server/db/cal_db_plugin_instance_localtime.c
+++ b/server/db/cal_db_plugin_instance_localtime.c
@@ -191,6 +191,8 @@ static int _cal_db_instance_localtime_get_records_with_query(calendar_query_h qu
 
        /* make: projection */
        ret = cal_db_query_create_projection(query, &projection);
+       if (ret = CALENDAR_ERROR_NONE)
+               ERR("cal_db_query_create_projection() Fail(%d) \n", ret);
 
        char *query_str = NULL;
        /* query: projection */
@@ -216,6 +218,8 @@ static int _cal_db_instance_localtime_get_records_with_query(calendar_query_h qu
        /* order */
        char *order = NULL;
        ret = cal_db_query_create_order(query, condition, &order);
+       if (ret = CALENDAR_ERROR_NONE)
+               ERR("cal_db_query_create_order() Fail(%d) \n", ret);
        if (order) {
                cal_db_append_string(&query_str, order);
                CAL_FREE(order);

diff --git a/server/db/cal_db_plugin_instance_utime.c b/server/db/cal_db_plugin_instance_utime.c
index 0ef8e77..14beba4 100644 (file)
--- a/server/db/cal_db_plugin_instance_utime.c
+++ b/server/db/cal_db_plugin_instance_utime.c
@@ -195,6 +195,8 @@ static int _cal_db_instance_utime_get_records_with_query(calendar_query_h query,
 
        /* make: projection */
        ret = cal_db_query_create_projection(query, &projection);
+       if (ret != CALENDAR_ERROR_NONE)
+               ERR("cal_db_query_create_projection() Fail(%d)", ret);
 
        char *query_str = NULL;
        /* query: projection */
@@ -220,6 +222,8 @@ static int _cal_db_instance_utime_get_records_with_query(calendar_query_h query,
        /* order */
        char *order = NULL;
        ret = cal_db_query_create_order(query, condition, &order);
+       if (ret != CALENDAR_ERROR_NONE)
+               ERR("cal_db_query_create_order() Fail(%d)", ret);
        if (order) {
                cal_db_append_string(&query_str, order);
                CAL_FREE(order);