misc: microchip: pci1xxxx: Do not disable the pci device twice in gp_aux_bus_remove()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 18 Sep 2022 06:27:24 +0000 (08:27 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 22 Sep 2022 14:54:31 +0000 (16:54 +0200)
gp_aux_bus_probe() uses pcim_enable_device(), so there is no point in
calling pci_disable_device() explicitly in the remove function.

Fixes: 393fc2f5948f ("misc: microchip: pci1xxxx: load auxiliary bus driver for the PIO function in the multi-function endpoint of pci1xxxx device.")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/8a3a385b3ae15ee7497469ec3250302b626a018b.1663482259.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c

index edff3ee73f6f2f8b1b4cefa311a2e07332b89aca..6c4f8384aa090a95039e43727983d131c3874e3a 100644 (file)
@@ -139,7 +139,6 @@ static void gp_aux_bus_remove(struct pci_dev *pdev)
        auxiliary_device_delete(&aux_bus->aux_device_wrapper[1]->aux_dev);
        auxiliary_device_uninit(&aux_bus->aux_device_wrapper[1]->aux_dev);
        kfree(aux_bus);
-       pci_disable_device(pdev);
 }
 
 static const struct pci_device_id pci1xxxx_tbl[] = {