media: i2c: ov5675: parse and register V4L2 device tree properties
authorQuentin Schulz <quentin.schulz@theobroma-systems.com>
Wed, 8 Jun 2022 13:44:19 +0000 (15:44 +0200)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Mon, 6 Feb 2023 07:44:28 +0000 (08:44 +0100)
Parse V4L2 device tree properties and register controls for them.

Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/i2c/ov5675.c

index 6fb849d..b1ed437 100644 (file)
@@ -779,12 +779,14 @@ static const struct v4l2_ctrl_ops ov5675_ctrl_ops = {
 
 static int ov5675_init_controls(struct ov5675 *ov5675)
 {
+       struct i2c_client *client = v4l2_get_subdevdata(&ov5675->sd);
+       struct v4l2_fwnode_device_properties props;
        struct v4l2_ctrl_handler *ctrl_hdlr;
        s64 exposure_max, h_blank;
        int ret;
 
        ctrl_hdlr = &ov5675->ctrl_handler;
-       ret = v4l2_ctrl_handler_init(ctrl_hdlr, 8);
+       ret = v4l2_ctrl_handler_init(ctrl_hdlr, 10);
        if (ret)
                return ret;
 
@@ -840,9 +842,23 @@ static int ov5675_init_controls(struct ov5675 *ov5675)
                return ctrl_hdlr->error;
        }
 
+       ret = v4l2_fwnode_device_parse(&client->dev, &props);
+       if (ret)
+               goto error;
+
+       ret = v4l2_ctrl_new_fwnode_properties(ctrl_hdlr, &ov5675_ctrl_ops,
+                                             &props);
+       if (ret)
+               goto error;
+
        ov5675->sd.ctrl_handler = ctrl_hdlr;
 
        return 0;
+
+error:
+       v4l2_ctrl_handler_free(ctrl_hdlr);
+
+       return ret;
 }
 
 static void ov5675_update_pad_format(const struct ov5675_mode *mode,