evas - generic loaders - fix possible string overflow on decoders
authorJaehyun Cho <jae_hyun.cho@samsung.com>
Wed, 17 Dec 2014 08:48:51 +0000 (17:48 +0900)
committerCarsten Haitzler (Rasterman) <raster@rasterman.com>
Wed, 17 Dec 2014 08:49:07 +0000 (17:49 +0900)
Summary:
fix possible string overflow on decoders.
         this commit is based on commit 3c5412f72879bbce72bfbc7190acd9e5d16d3b46
         that fixes CID 1039580.

Reviewers: raster

Reviewed By: raster

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1783

src/modules/evas/loaders/generic/evas_image_load_generic.c

index 22d0acde276cf4b2c5e8314e002becec803a7622..78488d103697039348963449db29e3a34d024d2a 100644 (file)
@@ -173,7 +173,8 @@ _load(Eina_File *ef, const char *key,
         // single extn not too long
         if (((end - dot1) <= 5) && (!illegal_char(dot1)))
           {
-             strcpy(&(decoders[decoders_num][0]), img_loader);
+             strncpy(&(decoders[decoders_num][0]), img_loader, 127);
+             decoders[decoders_num][127] = 0;
              dotcat(&(decoders[decoders_num][0]), dot1);
              decoders_num++;
           }