IB/hifi1: add a null check of kzalloc_node in hfi1_ipoib_txreq_init
authorKang Chen <void0red@gmail.com>
Mon, 27 Feb 2023 10:02:12 +0000 (18:02 +0800)
committerLeon Romanovsky <leon@kernel.org>
Mon, 13 Mar 2023 11:51:28 +0000 (13:51 +0200)
kzalloc_node may fails, check it and do the cleanup.

Fixes: b1151b74ff68 ("IB/hfi1: Fix alloc failure with larger txqueuelen")
Signed-off-by: Kang Chen <void0red@gmail.com>
Link: https://lore.kernel.org/r/20230227100212.910820-1-void0red@gmail.com
Signed-off-by: Leon Romanovsky <leon@kernel.org>
drivers/infiniband/hw/hfi1/ipoib_tx.c

index 5d9a7b0..349eb41 100644 (file)
@@ -737,10 +737,13 @@ int hfi1_ipoib_txreq_init(struct hfi1_ipoib_dev_priv *priv)
                txq->tx_ring.shift = ilog2(tx_item_size);
                txq->tx_ring.avail = hfi1_ipoib_ring_hwat(txq);
                tx_ring = &txq->tx_ring;
-               for (j = 0; j < tx_ring_size; j++)
+               for (j = 0; j < tx_ring_size; j++) {
                        hfi1_txreq_from_idx(tx_ring, j)->sdma_hdr =
                                kzalloc_node(sizeof(*tx->sdma_hdr),
                                             GFP_KERNEL, priv->dd->node);
+                       if (!hfi1_txreq_from_idx(tx_ring, j)->sdma_hdr)
+                               goto free_txqs;
+               }
 
                netif_napi_add_tx(dev, &txq->napi, hfi1_ipoib_poll_tx_ring);
        }