scsi: mpi3mr: Remove unnecessary cast
authorJules Irenge <jbi.octave@gmail.com>
Mon, 12 Sep 2022 21:29:11 +0000 (22:29 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sun, 25 Sep 2022 18:22:56 +0000 (14:22 -0400)
coccinelle reports a warning:

  WARNING: casting value returned by memory allocation function to (struct
  mpi3mr_throttle_group_info *) is useless

To fix this, the unnecessary cast is removed.

Link: https://lore.kernel.org/r/Yx+kp8NxHvDHs7dv@playground
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/mpi3mr/mpi3mr_fw.c

index d5da49a..0c4aaba 100644 (file)
@@ -3894,8 +3894,7 @@ retry_init:
        if (!mrioc->throttle_groups && mrioc->num_io_throttle_group) {
                dprint_init(mrioc, "allocating memory for throttle groups\n");
                sz = sizeof(struct mpi3mr_throttle_group_info);
-               mrioc->throttle_groups = (struct mpi3mr_throttle_group_info *)
-                   kcalloc(mrioc->num_io_throttle_group, sz, GFP_KERNEL);
+               mrioc->throttle_groups = kcalloc(mrioc->num_io_throttle_group, sz, GFP_KERNEL);
                if (!mrioc->throttle_groups)
                        goto out_failed_noretry;
        }