Removing unused functions and variables. Fixing warnings.

Change-Id: I097c3eacbc4f67e424c7a340ed4e80806b9cb54e

diff --git a/src/common/pkgmgr_signal.cc b/src/common/pkgmgr_signal.cc
index 9fec796..186003f 100644 (file)
--- a/src/common/pkgmgr_signal.cc
+++ b/src/common/pkgmgr_signal.cc
@@ -68,10 +68,6 @@ bool PkgmgrSignal::SendFinished(
   return true;
 }
 
-bool PkgmgrSignal::IsFinished() const {
-  return state_ == State::FINISHED;
-}
-
 bool PkgmgrSignal::SendSignal(
     const char* key,
     const char* value,

diff --git a/src/tpk/step/step_parse.cc b/src/tpk/step/step_parse.cc
index 961b021..a083999 100644 (file)
--- a/src/tpk/step/step_parse.cc
+++ b/src/tpk/step/step_parse.cc
@@ -17,6 +17,7 @@ using xml_parser::XmlElement;
 
 
 namespace tpk {
+
 namespace parse {
 
 namespace {

diff --git a/src/tpk/xml_parser/xml_parser.cc b/src/tpk/xml_parser/xml_parser.cc
index a8b1fb4..1c70a4a 100644 (file)
--- a/src/tpk/xml_parser/xml_parser.cc
+++ b/src/tpk/xml_parser/xml_parser.cc
@@ -49,12 +49,10 @@ const string& XmlElement::attr(const string& attrName) {
 
 void XmlElement::SetAttrMap(xmlNode* node) {
   xmlAttr* attr;
-  const xmlChar* name;
-  xmlChar* value;
 
   for (attr=node->properties; attr != nullptr; attr=attr->next) {
-    name = attr->name;
-    value = xmlGetProp(node, name);  // NOTE: Needs to be freed
+    const xmlChar* name = attr->name;
+    xmlChar* value = xmlGetProp(node, name);  // NOTE: Needs to be freed
 
     attr_map_.insert(map<string, string>::value_type(
           xmlChar2string(name), xmlChar2string(value)));

diff --git a/src/unit_tests/xml_parser_unittest.cc b/src/unit_tests/xml_parser_unittest.cc
index ef71e2a..642be04 100644 (file)
--- a/src/unit_tests/xml_parser_unittest.cc
+++ b/src/unit_tests/xml_parser_unittest.cc
@@ -21,11 +21,6 @@ using xml_parser::XmlParser;
 namespace bf = boost::filesystem;
 
 class TestXmlParser : public testing::Test {
- protected:
-  virtual void SetUp() {
-  }
-  virtual void TearDown() {
-  }
 };
 
 // Tests manifest parser with proper manifest