[media] wl128x: Replace memcpy with struct assignment
authorEzequiel Garcia <elezegarcia@gmail.com>
Tue, 23 Oct 2012 18:57:26 +0000 (15:57 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 27 Dec 2012 21:03:46 +0000 (19:03 -0200)
This kind of memcpy() is error-prone. Its replacement with a struct
assignment is prefered because it's type-safe and much easier to read.
Found by coccinelle. Hand patched and reviewed.
Tested by compilation only.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier struct_name;
struct struct_name to;
struct struct_name from;
expression E;
@@
-memcpy(&(to), &(from), E);
+to = from;
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/radio/wl128x/fmdrv_common.c

index 602ef7a..a002234 100644 (file)
@@ -1563,8 +1563,7 @@ int fmc_prepare(struct fmdev *fmdev)
        fmdev->irq_info.mask = FM_MAL_EVENT;
 
        /* Region info */
-       memcpy(&fmdev->rx.region, &region_configs[default_radio_region],
-                       sizeof(struct region_info));
+       fmdev->rx.region = region_configs[default_radio_region];
 
        fmdev->rx.mute_mode = FM_MUTE_OFF;
        fmdev->rx.rf_depend_mute = FM_RX_RF_DEPENDENT_MUTE_OFF;