rxrpc: Fix switched parameters in peer tracing
authorDavid Howells <dhowells@redhat.com>
Thu, 15 Dec 2022 16:20:30 +0000 (16:20 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 19 Dec 2022 09:51:31 +0000 (09:51 +0000)
Fix the switched parameters on rxrpc_alloc_peer() and rxrpc_get_peer().
The ref argument and the why argument got mixed.

Fixes: 47c810a79844 ("rxrpc: trace: Don't use __builtin_return_address for rxrpc_peer tracing")
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
Signed-off-by: David S. Miller <davem@davemloft.net>
include/trace/events/rxrpc.h
net/rxrpc/peer_object.c

index 049b52e..c6cfed0 100644 (file)
@@ -471,7 +471,7 @@ TRACE_EVENT(rxrpc_peer,
            TP_STRUCT__entry(
                    __field(unsigned int,       peer            )
                    __field(int,                ref             )
-                   __field(int,                why             )
+                   __field(enum rxrpc_peer_trace, why          )
                             ),
 
            TP_fast_assign(
index 82de295..4eecea2 100644 (file)
@@ -226,7 +226,7 @@ struct rxrpc_peer *rxrpc_alloc_peer(struct rxrpc_local *local, gfp_t gfp,
                rxrpc_peer_init_rtt(peer);
 
                peer->cong_ssthresh = RXRPC_TX_MAX_WINDOW;
-               trace_rxrpc_peer(peer->debug_id, why, 1);
+               trace_rxrpc_peer(peer->debug_id, 1, why);
        }
 
        _leave(" = %p", peer);
@@ -382,7 +382,7 @@ struct rxrpc_peer *rxrpc_get_peer(struct rxrpc_peer *peer, enum rxrpc_peer_trace
        int r;
 
        __refcount_inc(&peer->ref, &r);
-       trace_rxrpc_peer(peer->debug_id, why, r + 1);
+       trace_rxrpc_peer(peer->debug_id, r + 1, why);
        return peer;
 }