staging: Android: Fix some checkpatch warnings
authorSachin Kamat <sachin.kamat@linaro.org>
Tue, 5 Jun 2012 11:10:10 +0000 (16:40 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 12 Jun 2012 18:20:17 +0000 (11:20 -0700)
Warnings reported by checkpatch.pl have been fixed.

Cc: Brian Swetland <swetland@google.com>
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/android/ashmem.c
drivers/staging/android/logger.c
drivers/staging/android/ram_console.c
drivers/staging/android/timed_output.c

index e84dbec..69cf2db 100644 (file)
@@ -16,6 +16,8 @@
 ** GNU General Public License for more details.
 */
 
+#define pr_fmt(fmt) "ashmem: " fmt
+
 #include <linux/module.h>
 #include <linux/file.h>
 #include <linux/fs.h>
@@ -707,7 +709,7 @@ static int __init ashmem_init(void)
                                          sizeof(struct ashmem_area),
                                          0, 0, NULL);
        if (unlikely(!ashmem_area_cachep)) {
-               printk(KERN_ERR "ashmem: failed to create slab cache\n");
+               pr_err("failed to create slab cache\n");
                return -ENOMEM;
        }
 
@@ -715,19 +717,19 @@ static int __init ashmem_init(void)
                                          sizeof(struct ashmem_range),
                                          0, 0, NULL);
        if (unlikely(!ashmem_range_cachep)) {
-               printk(KERN_ERR "ashmem: failed to create slab cache\n");
+               pr_err("failed to create slab cache\n");
                return -ENOMEM;
        }
 
        ret = misc_register(&ashmem_misc);
        if (unlikely(ret)) {
-               printk(KERN_ERR "ashmem: failed to register misc device!\n");
+               pr_err("failed to register misc device!\n");
                return ret;
        }
 
        register_shrinker(&ashmem_shrinker);
 
-       printk(KERN_INFO "ashmem: initialized\n");
+       pr_info("initialized\n");
 
        return 0;
 }
@@ -740,12 +742,12 @@ static void __exit ashmem_exit(void)
 
        ret = misc_deregister(&ashmem_misc);
        if (unlikely(ret))
-               printk(KERN_ERR "ashmem: failed to unregister misc device!\n");
+               pr_err("failed to unregister misc device!\n");
 
        kmem_cache_destroy(ashmem_range_cachep);
        kmem_cache_destroy(ashmem_area_cachep);
 
-       printk(KERN_INFO "ashmem: unloaded\n");
+       pr_info("unloaded\n");
 }
 
 module_init(ashmem_init);
index b2e71c6..f7b8237 100644 (file)
@@ -17,6 +17,8 @@
  * GNU General Public License for more details.
  */
 
+#define pr_fmt(fmt) "logger: " fmt
+
 #include <linux/sched.h>
 #include <linux/module.h>
 #include <linux/fs.h>
@@ -621,13 +623,13 @@ static int __init create_log(char *log_name, int size)
        /* finally, initialize the misc device for this log */
        ret = misc_register(&log->misc);
        if (unlikely(ret)) {
-               printk(KERN_ERR "logger: failed to register misc "
-                      "device for log '%s'!\n", log->misc.name);
+               pr_err("failed to register misc device for log '%s'!\n",
+                               log->misc.name);
                goto out_free_log;
        }
 
-       printk(KERN_INFO "logger: created %luK log '%s'\n",
-              (unsigned long) log->size >> 10, log->misc.name);
+       pr_info("created %luK log '%s'\n",
+               (unsigned long) log->size >> 10, log->misc.name);
 
        return 0;
 
index 82323bb..7add022 100644 (file)
@@ -13,6 +13,8 @@
  *
  */
 
+#define pr_fmt(fmt) "ram_console: " fmt
+
 #include <linux/console.h>
 #include <linux/init.h>
 #include <linux/module.h>
@@ -162,7 +164,7 @@ static int __init ram_console_late_init(void)
 
        entry = create_proc_entry("last_kmsg", S_IFREG | S_IRUGO, NULL);
        if (!entry) {
-               printk(KERN_ERR "ram_console: failed to create proc entry\n");
+               pr_err("failed to create proc entry\n");
                persistent_ram_free_old(prz);
                return 0;
        }
index 38d930c..ec9e2ae 100644 (file)
@@ -14,6 +14,8 @@
  *
  */
 
+#define pr_fmt(fmt) "timed_output: " fmt
+
 #include <linux/module.h>
 #include <linux/types.h>
 #include <linux/device.h>
@@ -90,7 +92,7 @@ int timed_output_dev_register(struct timed_output_dev *tdev)
 
 err_create_file:
        device_destroy(timed_output_class, MKDEV(0, tdev->index));
-       printk(KERN_ERR "timed_output: Failed to register driver %s\n",
+       pr_err("failed to register driver %s\n",
                        tdev->name);
 
        return ret;