fotg210-udc: Remove a dubious condition leading to fotg210_done
authorFabian Vogt <fabian@ritter-vogt.de>
Wed, 24 Mar 2021 14:11:11 +0000 (15:11 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 26 Mar 2021 13:43:47 +0000 (14:43 +0100)
When the EP0 IN request was not completed but less than a packet sent,
it would complete the request successfully. That doesn't make sense
and can't really happen as fotg210_start_dma always sends
min(length, maxpkt) bytes.

Fixes: b84a8dee23fd ("usb: gadget: add Faraday fotg210_udc driver")
Signed-off-by: Fabian Vogt <fabian@ritter-vogt.de>
Link: https://lore.kernel.org/r/20210324141115.9384-4-fabian@ritter-vogt.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/udc/fotg210-udc.c

index 345827c..a3ad93b 100644 (file)
@@ -379,8 +379,7 @@ static void fotg210_ep0_queue(struct fotg210_ep *ep,
        }
        if (ep->dir_in) { /* if IN */
                fotg210_start_dma(ep, req);
-               if ((req->req.length == req->req.actual) ||
-                   (req->req.actual < ep->ep.maxpacket))
+               if (req->req.length == req->req.actual)
                        fotg210_done(ep, req, 0);
        } else { /* OUT */
                u32 value = ioread32(ep->fotg210->reg + FOTG210_DMISGR0);