tests: check for NULL before g_object_unref()
authorRyan Lortie <desrt@desrt.ca>
Wed, 4 Feb 2015 16:47:39 +0000 (17:47 +0100)
committerRyan Lortie <desrt@desrt.ca>
Tue, 17 Feb 2015 21:16:52 +0000 (16:16 -0500)
delayed_close_free() calls g_object_unref() on a variable that is
expected to possibly contain NULL (as indicated by the fact that the
NULL case is handled in my_slow_close_output_stream_close_async()).

This is dead code right now (due to a bug in GDBus), which is why it
isn't actually causing a failure.  It should still be fixed, however.

https://bugzilla.gnome.org/show_bug.cgi?id=743990

gio/tests/gdbus-close-pending.c

index c74ce66..762d931 100644 (file)
@@ -174,7 +174,8 @@ delayed_close_free (gpointer data)
   DelayedClose *df = data;
 
   g_object_unref (df->stream);
-  g_object_unref (df->cancellable);
+  if (df->cancellable)
+    g_object_unref (df->cancellable);
   g_free (df);
 }