ubifs: Fixed missed le64_to_cpu() in journal
authorBen Dooks (Codethink) <ben.dooks@codethink.co.uk>
Wed, 16 Oct 2019 10:08:03 +0000 (11:08 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 Jan 2020 18:49:00 +0000 (19:49 +0100)
commit df22b5b3ecc6233e33bd27f67f14c0cd1b5a5897 upstream.

In the ubifs_jnl_write_inode() functon, it calls ubifs_iget()
with xent->inum. The xent->inum is __le64, but the ubifs_iget()
takes native cpu endian.

I think that this should be changed to passing le64_to_cpu(xent->inum)
to fix the following sparse warning:

fs/ubifs/journal.c:902:58: warning: incorrect type in argument 2 (different base types)
fs/ubifs/journal.c:902:58:    expected unsigned long inum
fs/ubifs/journal.c:902:58:    got restricted __le64 [usertype] inum

Fixes: 7959cf3a7506 ("ubifs: journal: Handle xattrs like files")
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ubifs/journal.c

index 4fd9683..826dad0 100644 (file)
@@ -899,7 +899,7 @@ int ubifs_jnl_write_inode(struct ubifs_info *c, const struct inode *inode)
                        fname_name(&nm) = xent->name;
                        fname_len(&nm) = le16_to_cpu(xent->nlen);
 
-                       xino = ubifs_iget(c->vfs_sb, xent->inum);
+                       xino = ubifs_iget(c->vfs_sb, le64_to_cpu(xent->inum));
                        if (IS_ERR(xino)) {
                                err = PTR_ERR(xino);
                                ubifs_err(c, "dead directory entry '%s', error %d",