projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
facd31b
)
iommu/arm-smmu: qcom_iommu: Add of_node_put() when breaking out of loop
author
Liang He
<windhl@126.com>
Tue, 19 Jul 2022 12:49:55 +0000
(20:49 +0800)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Wed, 17 Aug 2022 12:24:09 +0000
(14:24 +0200)
[ Upstream commit
a91eb6803c1c715738682fece095145cbd68fe0b
]
In qcom_iommu_has_secure_context(), we should call of_node_put()
for the reference 'child' when breaking out of for_each_child_of_node()
which will automatically increase and decrease the refcount.
Fixes:
d051f28c8807
("iommu/qcom: Initialize secure page table")
Signed-off-by: Liang He <windhl@126.com>
Link:
https://lore.kernel.org/r/20220719124955.1242171-1-windhl@126.com
Signed-off-by: Will Deacon <will@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/iommu/arm/arm-smmu/qcom_iommu.c
patch
|
blob
|
history
diff --git
a/drivers/iommu/arm/arm-smmu/qcom_iommu.c
b/drivers/iommu/arm/arm-smmu/qcom_iommu.c
index
b91874c
..
a47cb65
100644
(file)
--- a/
drivers/iommu/arm/arm-smmu/qcom_iommu.c
+++ b/
drivers/iommu/arm/arm-smmu/qcom_iommu.c
@@
-748,9
+748,12
@@
static bool qcom_iommu_has_secure_context(struct qcom_iommu_dev *qcom_iommu)
{
struct device_node *child;
- for_each_child_of_node(qcom_iommu->dev->of_node, child)
- if (of_device_is_compatible(child, "qcom,msm-iommu-v1-sec"))
+ for_each_child_of_node(qcom_iommu->dev->of_node, child) {
+ if (of_device_is_compatible(child, "qcom,msm-iommu-v1-sec")) {
+ of_node_put(child);
return true;
+ }
+ }
return false;
}