Input: drv260x - switch to DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr()
authorJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 2 Jan 2023 18:17:36 +0000 (18:17 +0000)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 10 Jan 2023 04:25:20 +0000 (20:25 -0800)
SIMPLE_DEV_PM_OPS() is deprecated as it requires explicit protection
against unused function warnings.  The new combination of pm_sleep_ptr()
and DEFINE_SIMPLE_DEV_PM_OPS() allows the compiler to see the functions,
thus suppressing the warning, but still allowing the unused code to be
removed. Thus also drop the __maybe_unused markings.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20230102181842.718010-4-jic23@kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/misc/drv260x.c

index 3a51ee5e935a0c0a24f0369fcc1fc7aa5eb739f3..8a9ebfc04a2d95985363bbedf4fe9d868e4da06d 100644 (file)
@@ -572,7 +572,7 @@ static int drv260x_probe(struct i2c_client *client)
        return 0;
 }
 
-static int __maybe_unused drv260x_suspend(struct device *dev)
+static int drv260x_suspend(struct device *dev)
 {
        struct drv260x_data *haptics = dev_get_drvdata(dev);
        int ret = 0;
@@ -604,7 +604,7 @@ out:
        return ret;
 }
 
-static int __maybe_unused drv260x_resume(struct device *dev)
+static int drv260x_resume(struct device *dev)
 {
        struct drv260x_data *haptics = dev_get_drvdata(dev);
        int ret = 0;
@@ -635,7 +635,7 @@ out:
        return ret;
 }
 
-static SIMPLE_DEV_PM_OPS(drv260x_pm_ops, drv260x_suspend, drv260x_resume);
+static DEFINE_SIMPLE_DEV_PM_OPS(drv260x_pm_ops, drv260x_suspend, drv260x_resume);
 
 static const struct i2c_device_id drv260x_id[] = {
        { "drv2605l", 0 },
@@ -657,7 +657,7 @@ static struct i2c_driver drv260x_driver = {
        .driver         = {
                .name   = "drv260x-haptics",
                .of_match_table = drv260x_of_match,
-               .pm     = &drv260x_pm_ops,
+               .pm     = pm_sleep_ptr(&drv260x_pm_ops),
        },
        .id_table = drv260x_id,
 };