Fix select µsec calculation to avoid integer overflow.

Pointed out by Sergey Svishchev.

Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>

diff --git a/mainloop.c b/mainloop.c
index ca98f54..fac9ede 100644 (file)
--- a/mainloop.c
+++ b/mainloop.c
@@ -121,7 +121,7 @@ int vpn_mainloop(struct openconnect_info *vpninfo)
                memcpy(&efds, &vpninfo->select_efds, sizeof(efds));
 
                tv.tv_sec = timeout / 1000;
-               tv.tv_usec = (timeout * 1000) % 1000000;
+               tv.tv_usec = (timeout % 1000) * 1000;
                if (select(vpninfo->select_nfds, &rfds, &wfds, &efds, &tv) >= 0
                    && FD_ISSET(vpninfo->ssl_fd, &efds)) {
                        /* OpenSSL doesn't seem to cope properly with this... */