media: imx7-mipi-csis: make array 'registers' static const, makes object smaller
authorColin Ian King <colin.king@canonical.com>
Fri, 6 Sep 2019 15:08:23 +0000 (12:08 -0300)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Tue, 5 Nov 2019 11:29:50 +0000 (08:29 -0300)
Don't populate the array 'registers' on the stack but instead make it
static const. Makes the object code smaller by 10 bytes.

Before:
   text    data     bss     dec     hex filename
  20138    5196     128   25462    6376 staging/media/imx/imx7-mipi-csis.o

After:
   text    data     bss     dec     hex filename
  20032    5292     128   25452    636c staging/media/imx/imx7-mipi-csis.o

(gcc version 9.2.1, amd64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/staging/media/imx/imx7-mipi-csis.c

index 70b830d..99166af 100644 (file)
@@ -293,7 +293,7 @@ static int mipi_csis_dump_regs(struct csi_state *state)
        struct device *dev = &state->pdev->dev;
        unsigned int i;
        u32 cfg;
-       struct {
+       static const struct {
                u32 offset;
                const char * const name;
        } registers[] = {