thunderbolt: Fix xhci check in usb4_switch_setup()
authorMika Westerberg <mika.westerberg@linux.intel.com>
Wed, 8 Jan 2020 12:53:16 +0000 (15:53 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 8 Jan 2020 15:55:42 +0000 (16:55 +0100)
The code tried to check whether xhci variable has ROUTER_CS_6_HCI bit
set but since xhci type is bool and it already holds true or false based
on that very bit, fix the check to use the variable directly.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: b04079837b20 ("thunderbolt: Add initial support for USB4")
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Link: https://lore.kernel.org/r/20200108125317.36444-2-mika.westerberg@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/thunderbolt/usb4.c

index dbe7ecc..b341fc6 100644 (file)
@@ -239,7 +239,7 @@ int usb4_switch_setup(struct tb_switch *sw)
                 * and the parent does not have any USB3 dowstream
                 * adapters (so we cannot do USB 3.x tunneling).
                 */
-               if (xhci & ROUTER_CS_6_HCI)
+               if (xhci)
                        val |= ROUTER_CS_5_HCO;
        }