gst/gstregistrybinary.c: Return the old CRC instead of 0 if we give a NULL buffer...

Original commit message from CVS:
* gst/gstregistrybinary.c: (_gst_crc32):
Return the old CRC instead of 0 if we give a NULL buffer
or a buffer with a length of 0.

diff --git a/ChangeLog b/ChangeLog
index d30d15eae9a54567fe5cc0446c05f17754f35501..63b6dbb72d9b84350b2a61fd48eefd2a4bda8732 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2008-04-19  Sebastian Dröge  <slomo@circular-chaos.org>
+
+       * gst/gstregistrybinary.c: (_gst_crc32):
+       Return the old CRC instead of 0 if we give a NULL buffer
+       or a buffer with a length of 0.
+
 2008-04-19  Sebastian Dröge  <slomo@circular-chaos.org>
 
        * gst/gsturi.c: (gst_uri_protocol_check_internal),

diff --git a/gst/gstregistrybinary.c b/gst/gstregistrybinary.c
index 926b1972e5409964d06751d9c82a6574fd1292aa..d810c800a13ab8d2fcafc3853cf703c6366b336e 100644 (file)
--- a/gst/gstregistrybinary.c
+++ b/gst/gstregistrybinary.c
@@ -122,6 +122,7 @@
 /* Changes for gstreamer:
  * - Changed to use GLib data types
  * - Change function name to _gst_crc32
+ * - Return the old CRC instead of 0 when len or buf are 0/NULL
  */
 
 /* ========================================================================
@@ -192,8 +193,9 @@ static const guint32 crc_table[256] = {
 static guint32
 _gst_crc32 (guint32 crc, const gchar * buf, guint len)
 {
-  if (buf == NULL)
-    return 0L;
+  if (buf == NULL || len == 0)
+    return crc;
+
   crc = crc ^ 0xffffffffL;
   while (len >= 8) {
     DO8 (buf);