net: caif: remove ineffective check
authorPan Bian <bianpan2016@163.com>
Sun, 4 Dec 2016 04:15:44 +0000 (12:15 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 5 Dec 2016 19:48:48 +0000 (14:48 -0500)
The check of the return value of sock_register() is ineffective.
"if(!err)" seems to be a typo. It is better to propagate the error code
to the callers of caif_sktinit_module(). This patch removes the check
statment and directly returns the result of sock_register().

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188751
Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/caif/caif_socket.c

index aa209b1..92cbbd2 100644 (file)
@@ -1107,10 +1107,7 @@ static struct net_proto_family caif_family_ops = {
 
 static int __init caif_sktinit_module(void)
 {
-       int err = sock_register(&caif_family_ops);
-       if (!err)
-               return err;
-       return 0;
+       return sock_register(&caif_family_ops);
 }
 
 static void __exit caif_sktexit_module(void)