NFC: NCI: No need to reverse ATR_RES Response
authorHiren Tandel <hirent@marvell.com>
Tue, 6 May 2014 06:51:50 +0000 (15:51 +0900)
committerSamuel Ortiz <sameo@linux.intel.com>
Mon, 19 May 2014 21:58:08 +0000 (23:58 +0200)
ATR_RES response received within Activation Parameters is already
in correct order. Reversing it fails LLCP magic number check and
so P2P functionality fails.

Signed-off-by: Hiren Tandel <hirent@marvell.com>
Signed-off-by: Rahul Tank <rahult@marvell.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
net/nfc/nci/ntf.c

index 1e90509..f8f6af2 100644 (file)
@@ -366,7 +366,6 @@ static int nci_extract_activation_params_nfc_dep(struct nci_dev *ndev,
                        struct nci_rf_intf_activated_ntf *ntf, __u8 *data)
 {
        struct activation_params_poll_nfc_dep *poll;
-       int i;
 
        switch (ntf->activation_rf_tech_and_mode) {
        case NCI_NFC_A_PASSIVE_POLL_MODE:
@@ -374,10 +373,8 @@ static int nci_extract_activation_params_nfc_dep(struct nci_dev *ndev,
                poll = &ntf->activation_params.poll_nfc_dep;
                poll->atr_res_len = min_t(__u8, *data++, 63);
                pr_debug("atr_res_len %d\n", poll->atr_res_len);
-               if (poll->atr_res_len > 0) {
-                       for (i = 0; i < poll->atr_res_len; i++)
-                               poll->atr_res[poll->atr_res_len-1-i] = data[i];
-               }
+               if (poll->atr_res_len > 0)
+                       memcpy(poll->atr_res, data, poll->atr_res_len);
                break;
 
        default: