r8152: check if the pointer of the function exists
authorHayes Wang <hayeswang@realtek.com>
Fri, 19 Feb 2021 09:04:41 +0000 (17:04 +0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 23 Feb 2021 20:36:02 +0000 (12:36 -0800)
Return error code if autosuspend_en, eee_get, or eee_set don't exist.

Signed-off-by: Hayes Wang <hayeswang@realtek.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/usb/r8152.c

index 4bfee28..baa63ea 100644 (file)
@@ -5757,6 +5757,9 @@ static int rtl8152_runtime_suspend(struct r8152 *tp)
        struct net_device *netdev = tp->netdev;
        int ret = 0;
 
+       if (!tp->rtl_ops.autosuspend_en)
+               return -EBUSY;
+
        set_bit(SELECTIVE_SUSPEND, &tp->flags);
        smp_mb__after_atomic();
 
@@ -6156,6 +6159,11 @@ rtl_ethtool_get_eee(struct net_device *net, struct ethtool_eee *edata)
        struct r8152 *tp = netdev_priv(net);
        int ret;
 
+       if (!tp->rtl_ops.eee_get) {
+               ret = -EOPNOTSUPP;
+               goto out;
+       }
+
        ret = usb_autopm_get_interface(tp->intf);
        if (ret < 0)
                goto out;
@@ -6178,6 +6186,11 @@ rtl_ethtool_set_eee(struct net_device *net, struct ethtool_eee *edata)
        struct r8152 *tp = netdev_priv(net);
        int ret;
 
+       if (!tp->rtl_ops.eee_set) {
+               ret = -EOPNOTSUPP;
+               goto out;
+       }
+
        ret = usb_autopm_get_interface(tp->intf);
        if (ret < 0)
                goto out;