serial: mxc: have putc use the TXFIFO
authorJohannes Schneider <johannes.schneider@leica-geosystems.com>
Tue, 6 Sep 2022 12:15:04 +0000 (14:15 +0200)
committerStefano Babic <sbabic@denx.de>
Sun, 18 Sep 2022 20:56:10 +0000 (22:56 +0200)
only waiting for TXEMPTY leads to corrupted messages going over the
wire - which is fixed by making use of the FIFO

this change is following the linux kernel uart driver
(drivers/tty/serial/imx.c), which also checks UTS_TXFULL
instead of UTS_TXEMPTY

Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Fabio Estevam <festevam@denx.de>
drivers/serial/serial_mxc.c

index ee17a960d474f0a3e202de72f45462b3b28e4938..af1fd1ea9bc7c57458f5743c8a4d8ee1011ca7fc 100644 (file)
@@ -311,7 +311,7 @@ static int mxc_serial_putc(struct udevice *dev, const char ch)
        struct mxc_serial_plat *plat = dev_get_plat(dev);
        struct mxc_uart *const uart = plat->reg;
 
-       if (!(readl(&uart->ts) & UTS_TXEMPTY))
+       if (readl(&uart->ts) & UTS_TXFULL)
                return -EAGAIN;
 
        writel(ch, &uart->txd);