net: openvswitch: make EINVAL return value more obvious

Cc: Pravin B Shelar <pshelar@ovn.org>
Cc: Andy Zhou <azhou@ovn.org>
Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
Acked-by: Pravin B Shelar <pshelar@ovn.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/openvswitch/meter.c b/net/openvswitch/meter.c
index b7893b0..e36b464 100644 (file)
--- a/net/openvswitch/meter.c
+++ b/net/openvswitch/meter.c
@@ -419,9 +419,8 @@ static int ovs_meter_cmd_set(struct sk_buff *skb, struct genl_info *info)
        u32 meter_id;
        bool failed;
 
-       if (!a[OVS_METER_ATTR_ID]) {
-               return -ENODEV;
-       }
+       if (!a[OVS_METER_ATTR_ID])
+               return -EINVAL;
 
        meter = dp_meter_create(a);
        if (IS_ERR_OR_NULL(meter))