usb: phy: qcom: Use devm_ioremap_resource()
authorFabio Estevam <fabio.estevam@nxp.com>
Sun, 30 Jul 2017 00:58:56 +0000 (21:58 -0300)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Tue, 15 Aug 2017 09:46:02 +0000 (12:46 +0300)
Using devm_ioremap_resource() can make the code simpler, as it
already does the resource NULL check.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/phy/phy-qcom-8x16-usb.c

index b6a83a5..679afea 100644 (file)
@@ -270,12 +270,9 @@ static int phy_8x16_probe(struct platform_device *pdev)
        platform_set_drvdata(pdev, qphy);
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       if (!res)
-               return -EINVAL;
-
-       qphy->regs = devm_ioremap(&pdev->dev, res->start, resource_size(res));
-       if (!qphy->regs)
-               return -ENOMEM;
+       qphy->regs = devm_ioremap_resource(&pdev->dev, res);
+       if (IS_ERR(qphy->regs))
+               return PTR_ERR(qphy->regs);
 
        phy                     = &qphy->phy;
        phy->dev                = &pdev->dev;