staging: r8188eu: use pr_info_once() to log the firmware version

Use pr_info_once() instead of a static variable and an if statement
to log the firmware version only once.

Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20220417175441.13830-8-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/r8188eu/core/rtw_fw.c b/drivers/staging/r8188eu/core/rtw_fw.c
index 7fa985c..7c0653b 100644 (file)
--- a/drivers/staging/r8188eu/core/rtw_fw.c
+++ b/drivers/staging/r8188eu/core/rtw_fw.c
@@ -246,7 +246,6 @@ int rtl8188e_firmware_download(struct adapter *padapter)
        struct rt_firmware_hdr *fwhdr = NULL;
        u8 *fw_data;
        u32 fw_size;
-       static int log_version;
 
        if (!dvobj->firmware.data)
                ret = load_firmware(&dvobj->firmware, device);
@@ -260,10 +259,9 @@ int rtl8188e_firmware_download(struct adapter *padapter)
        /*  To Check Fw header. Added by tynli. 2009.12.04. */
        fwhdr = (struct rt_firmware_hdr *)dvobj->firmware.data;
 
-       if (!log_version++)
-               pr_info("%sFirmware Version %d, SubVersion %d, Signature 0x%x\n",
-                       DRIVER_PREFIX, le16_to_cpu(fwhdr->version), fwhdr->subversion,
-                       le16_to_cpu(fwhdr->signature));
+       pr_info_once("%sFirmware Version %d, SubVersion %d, Signature 0x%x\n",
+                    DRIVER_PREFIX, le16_to_cpu(fwhdr->version), fwhdr->subversion,
+                    le16_to_cpu(fwhdr->signature));
 
        if (IS_FW_HEADER_EXIST(fwhdr)) {
                fw_data = fw_data + sizeof(struct rt_firmware_hdr);