tipc: fix error handling in tipc_udp_enable()

Release alloced resource before return from the error handling
case in tipc_udp_enable(), otherwise will cause memory leak.

Fixes: 52dfae5c85a4 ("tipc: obtain node identity from interface by default")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/tipc/udp_media.c b/net/tipc/udp_media.c
index 2c13b18426d9db3f16ec79f2bea86ddc59601dc4..e7d91f5d5caed6f19f198ba91a24af9bf8ee51c2 100644 (file)
--- a/net/tipc/udp_media.c
+++ b/net/tipc/udp_media.c
@@ -687,7 +687,8 @@ static int tipc_udp_enable(struct net *net, struct tipc_bearer *b,
        }
        if (!tipc_own_id(net)) {
                pr_warn("Failed to set node id, please configure manually\n");
-               return -EINVAL;
+               err = -EINVAL;
+               goto err;
        }
 
        b->bcast_addr.media_id = TIPC_MEDIA_TYPE_UDP;