i2c: nvidia-gpu: Convert to use dev_err_probe()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 5 Jan 2022 14:19:34 +0000 (16:19 +0200)
committerWolfram Sang <wsa@kernel.org>
Tue, 15 Feb 2022 09:05:02 +0000 (10:05 +0100)
It's fine to call dev_err_probe() in ->probe() when error code is known.
Convert the driver to use dev_err_probe().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-nvidia-gpu.c

index a82be37..6920c1b 100644 (file)
@@ -282,24 +282,18 @@ static int gpu_i2c_probe(struct pci_dev *pdev, const struct pci_device_id *id)
        dev_set_drvdata(dev, i2cd);
 
        status = pcim_enable_device(pdev);
-       if (status < 0) {
-               dev_err(dev, "pcim_enable_device failed %d\n", status);
-               return status;
-       }
+       if (status < 0)
+               return dev_err_probe(dev, status, "pcim_enable_device failed\n");
 
        pci_set_master(pdev);
 
        i2cd->regs = pcim_iomap(pdev, 0, 0);
-       if (!i2cd->regs) {
-               dev_err(dev, "pcim_iomap failed\n");
-               return -ENOMEM;
-       }
+       if (!i2cd->regs)
+               return dev_err_probe(dev, -ENOMEM, "pcim_iomap failed\n");
 
        status = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_MSI);
-       if (status < 0) {
-               dev_err(dev, "pci_alloc_irq_vectors err %d\n", status);
-               return status;
-       }
+       if (status < 0)
+               return dev_err_probe(dev, status, "pci_alloc_irq_vectors err\n");
 
        gpu_enable_i2c_bus(i2cd);