Fix coverity issue 37/279737/1
authorJeongyoon Nam <just.nam@samsung.com>
Wed, 17 Aug 2022 05:33:38 +0000 (14:33 +0900)
committerJeongyoon Nam <just.nam@samsung.com>
Wed, 17 Aug 2022 05:36:25 +0000 (14:36 +0900)
- Unchecked return value

[Version] 0.0.6
[Issue Type] Coverity

Change-Id: I840c6d707b24b161edb74461f3ee6e63bbb2b710

packaging/esplusplayer.spec
src/plusplayer-core/src/gstsignal_holder.cpp

index 35ca39d..aa10061 100644 (file)
@@ -2,7 +2,7 @@
 %bcond_without ESPLUSPLAYER_UT
 Name:       esplusplayer
 Summary:    new multimedia streaming player
-Version:    0.0.5
+Version:    0.0.6
 Release:    0
 Group:      Multimedia/Libraries
 License:    Apache-2.0
index 9cce93c..837cb97 100644 (file)
@@ -62,9 +62,10 @@ void GstSignalHolder::Delete(GObject* obj) {
   std::lock_guard<std::mutex> guard(item_lock_);
   if (GST_IS_BIN(obj)) {
     GstIterator* it = gst_bin_iterate_elements(GST_BIN_CAST(obj));
-    gst_iterator_foreach(it,
+    while (gst_iterator_foreach(it,
                          (GstIteratorForeachFunction)internal::DisconnectSignal,
-                         (gpointer) this);
+                         (gpointer) this) == GST_ITERATOR_RESYNC)
+      gst_iterator_resync(it);
     gst_iterator_free(it);
   }
   signal_list_.erase(obj);