usb: gadget: composite: Fix bMaxPower for SuperSpeedPlus
authorJack Pham <jackp@codeaurora.org>
Fri, 31 Jan 2020 03:10:35 +0000 (19:10 -0800)
committerFelipe Balbi <balbi@kernel.org>
Tue, 11 Feb 2020 06:45:45 +0000 (08:45 +0200)
SuperSpeedPlus peripherals must report their bMaxPower of the
configuration descriptor in units of 8mA as per the USB 3.2
specification. The current switch statement in encode_bMaxPower()
only checks for USB_SPEED_SUPER but not USB_SPEED_SUPER_PLUS so
the latter falls back to USB 2.0 encoding which uses 2mA units.
Replace the switch with a simple if/else.

Fixes: eae5820b852f ("usb: gadget: composite: Write SuperSpeedPlus config descriptors")
Signed-off-by: Jack Pham <jackp@codeaurora.org>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
drivers/usb/gadget/composite.c

index 3b4f670..cd303a3 100644 (file)
@@ -437,12 +437,10 @@ static u8 encode_bMaxPower(enum usb_device_speed speed,
                val = CONFIG_USB_GADGET_VBUS_DRAW;
        if (!val)
                return 0;
-       switch (speed) {
-       case USB_SPEED_SUPER:
-               return DIV_ROUND_UP(val, 8);
-       default:
+       if (speed < USB_SPEED_SUPER)
                return DIV_ROUND_UP(val, 2);
-       }
+       else
+               return DIV_ROUND_UP(val, 8);
 }
 
 static int config_buf(struct usb_configuration *config,