mtd: onenand: omap2: add dependency on GPMC
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Mon, 7 Nov 2022 09:15:20 +0000 (10:15 +0100)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Mon, 7 Nov 2022 15:53:04 +0000 (16:53 +0100)
OMAP2 OneNAND driver uses gpmc_omap_onenand_set_timings() provided by
OMAP_GPMC driver, so the latter cannot be module if OneNAND driver is
built-in:

  /usr/bin/arm-linux-gnueabi-ld: drivers/mtd/nand/onenand/onenand_omap2.o: in function `omap2_onenand_probe':
  onenand_omap2.c:(.text+0x520): undefined reference to `gpmc_omap_onenand_set_timings'

The OMAP_GPMC is also a runtime dependency.

Reported-by: kernel test robot <lkp@intel.com>
Fixes: 854fd9209b20 ("memory: omap-gpmc: Allow building as a module")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20221107091520.127053-1-krzysztof.kozlowski@linaro.org
drivers/mtd/nand/onenand/Kconfig

index 34d9a7a..c94bf48 100644 (file)
@@ -26,6 +26,7 @@ config MTD_ONENAND_OMAP2
        tristate "OneNAND on OMAP2/OMAP3 support"
        depends on ARCH_OMAP2 || ARCH_OMAP3 || (COMPILE_TEST && ARM)
        depends on OF || COMPILE_TEST
+       depends on OMAP_GPMC
        help
          Support for a OneNAND flash device connected to an OMAP2/OMAP3 SoC
          via the GPMC memory controller.