-Wpointer-sign: ada-lang.c, ada-tasks.c.

We're reading strings using the target memory access routines, which
work with raw bytes, so we need a couple casts.

gdb/
2013-04-19  Pedro Alves  <palves@redhat.com>

	* ada-lang.c (print_it_exception): Add cast to gdb_byte *.
	* ada-tasks.c (read_fat_string_value): Likewise.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 61fba01..c265d24 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2013-04-19  Pedro Alves  <palves@redhat.com>
 
+       * ada-lang.c (print_it_exception): Add cast to gdb_byte *.
+       * ada-tasks.c (read_fat_string_value): Likewise.
+
+2013-04-19  Pedro Alves  <palves@redhat.com>
+
        * dwarf2-frame.c (execute_cfa_program): Make 'bytes_read' local
        unsigned.  Pass 'tmp' to safe_read_uleb128 instead of the signed
        'offset', and adjust.

diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index 4d07d4d..fdfc0b4 100644 (file)
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -11532,7 +11532,8 @@ print_it_exception (enum exception_catchpoint_kind ex, bpstat bs)
 
          if (addr != 0)
            {
-             read_memory (addr, exception_name, sizeof (exception_name) - 1);
+             read_memory (addr, (gdb_byte *) exception_name,
+                          sizeof (exception_name) - 1);
              exception_name [sizeof (exception_name) - 1] = '\0';
            }
          else

diff --git a/gdb/ada-tasks.c b/gdb/ada-tasks.c
index b0835f6..c5c7491 100644 (file)
--- a/gdb/ada-tasks.c
+++ b/gdb/ada-tasks.c
@@ -433,7 +433,7 @@ read_fat_string_value (char *dest, struct value *val, int max_len)
 
   /* Extract LEN characters from the fat string.  */
   array_val = value_ind (value_field (val, array_fieldno));
-  read_memory (value_address (array_val), dest, len);
+  read_memory (value_address (array_val), (gdb_byte *) dest, len);
 
   /* Add the NUL character to close the string.  */
   dest[len] = '\0';