virt/sev-guest: Remove unnecessary free in init_crypto()
authorRafael Mendonca <rafaelmendsr@gmail.com>
Tue, 18 Oct 2022 01:54:25 +0000 (22:54 -0300)
committerBorislav Petkov <bp@suse.de>
Thu, 27 Oct 2022 12:24:18 +0000 (14:24 +0200)
If the memory allocation for the auth tag fails, then there is no need
to free it.

Fixes: fce96cf04430 ("virt: Add SEV-SNP guest driver")
Signed-off-by: Rafael Mendonca <rafaelmendsr@gmail.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lore.kernel.org/r/20221018015425.887891-1-rafaelmendsr@gmail.com
drivers/virt/coco/sev-guest/sev-guest.c

index f422f9c..e9704ae 100644 (file)
@@ -152,12 +152,10 @@ static struct snp_guest_crypto *init_crypto(struct snp_guest_dev *snp_dev, u8 *k
        crypto->a_len = crypto_aead_authsize(crypto->tfm);
        crypto->authtag = kmalloc(crypto->a_len, GFP_KERNEL_ACCOUNT);
        if (!crypto->authtag)
-               goto e_free_auth;
+               goto e_free_iv;
 
        return crypto;
 
-e_free_auth:
-       kfree(crypto->authtag);
 e_free_iv:
        kfree(crypto->iv);
 e_free_crypto: