tests: prefer `skip_' over `echo ...; Exit 77'

* tests/self-check-cleanup.test: When the test must be skipped,
use `skip_ REASON' instead of `echo REASON; Exit 77'.  Also,
make the skip message shorter and clearer.

diff --git a/ChangeLog b/ChangeLog
index 7100f28..cc9dd2e 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
 2011-06-01  Stefano Lattarini  <stefano.lattarini@gmail.com>
 
+       tests: prefer `skip_' over `echo ...; Exit 77'
+       * tests/self-check-cleanup.test: When the test must be skipped,
+       use `skip_ REASON' instead of `echo REASON; Exit 77'.  Also,
+       make the skip message shorter and clearer.
+
+2011-06-01  Stefano Lattarini  <stefano.lattarini@gmail.com>
+
        tests: fix spurious failures in self tests
        Our ad-hoc usage of `tests/defs' in the testsuite's self tests
        stopped working properly when we made the test scripts re-execute

diff --git a/tests/self-check-cleanup.test b/tests/self-check-cleanup.test
index f9a8658..7660316 100755 (executable)
--- a/tests/self-check-cleanup.test
+++ b/tests/self-check-cleanup.test
@@ -20,8 +20,7 @@
 . ./defs || Exit 1
 
 if test x"$sh_errexit_works" != x"yes"; then
-  echo "$me: the shell can't have a working exit trap with 'set -e'" >&2
-  Exit 77
+  skip_ "$me: no working exit trap with 'set -e'"
 fi
 
 # We still need a little hack to make ./defs work outside automake's