drm/msm: wait_for_completion_timeout return is never negative
authorNicholas Mc Guire <hofrat@osadl.org>
Sat, 11 Apr 2015 13:10:37 +0000 (15:10 +0200)
committerRob Clark <robdclark@gmail.com>
Thu, 11 Jun 2015 17:11:03 +0000 (13:11 -0400)
wait_for_completion_timeout returns >= 0 but never
negative  - so the error check should be against equality
to 0 not <= 0.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Signed-off-by: Rob Clark <robdclark@gmail.com>
drivers/gpu/drm/msm/edp/edp_ctrl.c

index 17ae0cc..43e549b 100644 (file)
@@ -1032,7 +1032,7 @@ static void edp_ctrl_off_worker(struct work_struct *work)
 
        time_left = wait_for_completion_timeout(&ctrl->idle_comp,
                                                msecs_to_jiffies(500));
-       if (time_left <= 0)
+       if (!time_left)
                DBG("%s: idle pattern timedout, %lu\n",
                                __func__, time_left);