s3c-adc-battery: Fix possible NULL pointer dereference
authorSyam Sidhardhan <syamsidhardh@gmail.com>
Sun, 24 Feb 2013 23:03:25 +0000 (04:33 +0530)
committerAnton Vorontsov <anton@enomsg.org>
Tue, 19 Mar 2013 02:43:03 +0000 (19:43 -0700)
Check for (bat == NULL) has to be done before accessing bat

Signed-off-by: Syam Sidhardhan <s.syam@samsung.com>
Signed-off-by: Anton Vorontsov <anton@enomsg.org>
drivers/power/s3c_adc_battery.c

index d2ca989..5948ce0 100644 (file)
@@ -145,14 +145,17 @@ static int s3c_adc_bat_get_property(struct power_supply *psy,
 
        int new_level;
        int full_volt;
-       const struct s3c_adc_bat_thresh *lut = bat->pdata->lut_noac;
-       unsigned int lut_size = bat->pdata->lut_noac_cnt;
+       const struct s3c_adc_bat_thresh *lut;
+       unsigned int lut_size;
 
        if (!bat) {
                dev_err(psy->dev, "no battery infos ?!\n");
                return -EINVAL;
        }
 
+       lut = bat->pdata->lut_noac;
+       lut_size = bat->pdata->lut_noac_cnt;
+
        if (bat->volt_value < 0 || bat->cur_value < 0 ||
                jiffies_to_msecs(jiffies - bat->timestamp) >
                        BAT_POLL_INTERVAL) {