drm/vc4: Drop WARN for HVS FIFOs not being empty
authorDave Stevenson <dave.stevenson@raspberrypi.com>
Thu, 26 Oct 2023 17:05:09 +0000 (18:05 +0100)
committerDom Cobley <popcornmix@gmail.com>
Mon, 19 Feb 2024 11:35:11 +0000 (11:35 +0000)
The reset condition for the EMPTY flag in DISPSTATx is 0,
so seeing as we've just reset the pipeline there is no
guarantee that the flag will denote empty if it hasn't been
enabled.

Drop the WARN.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
drivers/gpu/drm/vc4/vc4_hvs.c

index 13ea95d..821bb99 100644 (file)
@@ -1005,10 +1005,6 @@ static void __vc4_hvs_stop_channel(struct vc4_hvs *hvs, unsigned int chan)
                                   SCALER_DISPSTATX_MODE) !=
                     SCALER_DISPSTATX_MODE_DISABLED);
 
-       WARN_ON_ONCE((HVS_READ(SCALER_DISPSTATX(chan)) &
-                     (SCALER_DISPSTATX_FULL | SCALER_DISPSTATX_EMPTY)) !=
-                    SCALER_DISPSTATX_EMPTY);
-
 out:
        drm_dev_exit(idx);
 }