drm/gpu: Fix Memory barrier without comment Issue
authorBhanusree <bhanusreemahesh@gmail.com>
Fri, 25 Oct 2019 06:27:38 +0000 (11:57 +0530)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 25 Oct 2019 07:35:06 +0000 (09:35 +0200)
-Issue found using checkpatch.pl
-Insert comments for memory barrier usage

Signed-off-by: Bhanusree <bhanusreemahesh@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/1571984858-4644-1-git-send-email-bhanusreemahesh@gmail.com
drivers/gpu/drm/drm_cache.c

index 12f8d1b..03e01b0 100644 (file)
@@ -126,10 +126,10 @@ drm_clflush_sg(struct sg_table *st)
        if (static_cpu_has(X86_FEATURE_CLFLUSH)) {
                struct sg_page_iter sg_iter;
 
-               mb();
+               mb(); /*CLFLUSH is ordered only by using memory barriers*/
                for_each_sg_page(st->sgl, &sg_iter, st->nents, 0)
                        drm_clflush_page(sg_page_iter_page(&sg_iter));
-               mb();
+               mb(); /*Make sure that all cache line entry is flushed*/
 
                return;
        }
@@ -160,11 +160,11 @@ drm_clflush_virt_range(void *addr, unsigned long length)
                void *end = addr + length;
 
                addr = (void *)(((unsigned long)addr) & -size);
-               mb();
+               mb(); /*CLFLUSH is only ordered with a full memory barrier*/
                for (; addr < end; addr += size)
                        clflushopt(addr);
                clflushopt(end - 1); /* force serialisation */
-               mb();
+               mb(); /*Ensure that evry data cache line entry is flushed*/
                return;
        }