radeon_cp: Remove unneeded tests for NULL before calling release_firmware()
authorJesper Juhl <jj@chaosbits.net>
Mon, 9 Apr 2012 20:49:57 +0000 (22:49 +0200)
committerJiri Kosina <jkosina@suse.cz>
Mon, 30 Apr 2012 11:15:31 +0000 (13:15 +0200)
release_firmware() does its own tests for NULL pointers so there's no
need to explicitly test before calling it.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/gpu/drm/radeon/radeon_cp.c

index 0ebb7d4..ef67e18 100644 (file)
@@ -1827,14 +1827,10 @@ void radeon_do_release(struct drm_device * dev)
                        r600_do_cleanup_cp(dev);
                else
                        radeon_do_cleanup_cp(dev);
-               if (dev_priv->me_fw) {
-                       release_firmware(dev_priv->me_fw);
-                       dev_priv->me_fw = NULL;
-               }
-               if (dev_priv->pfp_fw) {
-                       release_firmware(dev_priv->pfp_fw);
-                       dev_priv->pfp_fw = NULL;
-               }
+               release_firmware(dev_priv->me_fw);
+               dev_priv->me_fw = NULL;
+               release_firmware(dev_priv->pfp_fw);
+               dev_priv->pfp_fw = NULL;
        }
 }