ALSA: firewire-lib: Add 'direction' member to 'cmp_connection' structure
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Fri, 25 Apr 2014 13:44:55 +0000 (22:44 +0900)
committerTakashi Iwai <tiwai@suse.de>
Mon, 26 May 2014 12:22:14 +0000 (14:22 +0200)
This patch adds 'direction' member to 'cmp_connection' structure to indicate
the direction of connection. This patch also adds 'direction' argument to
cmp_connection_init() function to determine the direction.

The cmp_connection_init() function is exported and used in snd-firewire-speakers
so this patch also affect it.

This patch just add them. Actual implementation will be done by followed
patches.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/cmp.c
sound/firewire/cmp.h
sound/firewire/speakers.c

index deb494d..c7f7a31 100644 (file)
@@ -94,6 +94,7 @@ static int pcr_modify(struct cmp_connection *c,
  */
 int cmp_connection_init(struct cmp_connection *c,
                        struct fw_unit *unit,
+                       enum cmp_direction direction,
                        unsigned int pcr_index)
 {
        __be32 mpr_be;
index 2320cd4..9b58448 100644 (file)
@@ -7,6 +7,11 @@
 
 struct fw_unit;
 
+enum cmp_direction {
+       CMP_INPUT = 0,
+       CMP_OUTPUT,
+};
+
 /**
  * struct cmp_connection - manages an isochronous connection to a device
  * @speed: the connection's actual speed
@@ -26,10 +31,12 @@ struct cmp_connection {
        __be32 last_pcr_value;
        unsigned int pcr_index;
        unsigned int max_speed;
+       enum cmp_direction direction;
 };
 
 int cmp_connection_init(struct cmp_connection *connection,
                        struct fw_unit *unit,
+                       enum cmp_direction direction,
                        unsigned int pcr_index);
 void cmp_connection_destroy(struct cmp_connection *connection);
 
index 58e7ab0..dd9983b 100644 (file)
@@ -673,7 +673,7 @@ static int fwspk_probe(struct fw_unit *unit,
        fwspk->unit = fw_unit_get(unit);
        fwspk->device_info = (const struct device_info *)id->driver_data;
 
-       err = cmp_connection_init(&fwspk->connection, unit, 0);
+       err = cmp_connection_init(&fwspk->connection, unit, CMP_INPUT, 0);
        if (err < 0)
                goto err_unit;