leds: tlc591xx: add missing of_node_put

for_each_child_of_node performs an of_node_get on each iteration, so a
return from the loop requires an of_node_put.

The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr):

// <smpl>
@@
local idexpression n;
expression e,e1;
iterator name for_each_child_of_node;
@@

 for_each_child_of_node(e1,n) {
   ...
(
   of_node_put(n);
|
   e = n
|
   return n;
|
+  of_node_put(n);
?  return ...;
)
   ...
 }
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>

diff --git a/drivers/leds/leds-tlc591xx.c b/drivers/leds/leds-tlc591xx.c
index fcc87ee..f5357f6 100644 (file)
--- a/drivers/leds/leds-tlc591xx.c
+++ b/drivers/leds/leds-tlc591xx.c
@@ -230,11 +230,15 @@ tlc591xx_probe(struct i2c_client *client,
 
        for_each_child_of_node(np, child) {
                err = of_property_read_u32(child, "reg", &reg);
-               if (err)
+               if (err) {
+                       of_node_put(child);
                        return err;
+               }
                if (reg < 0 || reg >= tlc591xx->max_leds ||
-                   priv->leds[reg].active)
+                   priv->leds[reg].active) {
+                       of_node_put(child);
                        return -EINVAL;
+               }
                priv->leds[reg].active = true;
                priv->leds[reg].ldev.name =
                        of_get_property(child, "label", NULL) ? : child->name;