gpio: sim: Use correct order for the parameters of devm_kcalloc()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Fri, 20 May 2022 19:21:56 +0000 (21:21 +0200)
committerBartosz Golaszewski <brgl@bgdev.pl>
Sun, 22 May 2022 20:09:50 +0000 (22:09 +0200)
We should have 'n', then 'size', not the opposite.
This is harmless because the 2 values are just multiplied, but having
the correct order silence a (unpublished yet) smatch warning.

Fixes: cb8c474e79be ("gpio: sim: new testing module")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
drivers/gpio/gpio-sim.c

index 8e5d87984a48957d9a7c4856511a490e0978f45a..23433749782609270674e99caf8d576824fa0086 100644 (file)
@@ -314,8 +314,8 @@ static int gpio_sim_setup_sysfs(struct gpio_sim_chip *chip)
 
        for (i = 0; i < num_lines; i++) {
                attr_group = devm_kzalloc(dev, sizeof(*attr_group), GFP_KERNEL);
-               attrs = devm_kcalloc(dev, sizeof(*attrs),
-                                    GPIO_SIM_NUM_ATTRS, GFP_KERNEL);
+               attrs = devm_kcalloc(dev, GPIO_SIM_NUM_ATTRS, sizeof(*attrs),
+                                    GFP_KERNEL);
                val_attr = devm_kzalloc(dev, sizeof(*val_attr), GFP_KERNEL);
                pull_attr = devm_kzalloc(dev, sizeof(*pull_attr), GFP_KERNEL);
                if (!attr_group || !attrs || !val_attr || !pull_attr)